Skip to content

Navigate cleanup#9202

Merged
bramkragten merged 4 commits intodevfrom
navigate-cleanup
May 25, 2021
Merged

Navigate cleanup#9202
bramkragten merged 4 commits intodevfrom
navigate-cleanup

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented May 18, 2021

Breaking change

Proposed change

Removes the first argument to navigate (which was not used), and changes the now second to be an object which will make changing it in the future be easier

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

await showAlertDialog(this, {
text: "Add-on is not running. Please start it first",
title: addon.name,
confirm: () => navigate(`/hassio/addon/${addon.slug}`),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No replace anymore?

@bramkragten bramkragten merged commit 21a3a8c into dev May 25, 2021
@bramkragten bramkragten deleted the navigate-cleanup branch May 25, 2021 15:46
@bramkragten bramkragten mentioned this pull request May 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants