Skip to content

Make chrome work-around work in iframes#9200

Merged
bramkragten merged 1 commit intodevfrom
make-chrome-workaround-work-in-iframes
May 21, 2021
Merged

Make chrome work-around work in iframes#9200
bramkragten merged 1 commit intodevfrom
make-chrome-workaround-work-in-iframes

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented May 18, 2021

Proposed change

This finds our top window element, and not a top window that doesn't belong to us.

Fixes an issue if HA was used inside of an iFrame.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit fd9bb4d into dev May 21, 2021
@bramkragten bramkragten deleted the make-chrome-workaround-work-in-iframes branch May 21, 2021 07:09
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HA not loading within iFrame

3 participants