Skip to content

Add tsc and eslint to pre-commit #9131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
May 7, 2021
Merged

Add tsc and eslint to pre-commit #9131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c520791
Add tsc and eslint to pre-commit
bramkragten May 7, 2021
7bf7197
Bump lint-staged
bramkragten May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lint-staged.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module.exports = {
"*.ts": () => "tsc -p tsconfig.json",
Copy link
Copy Markdown
Member

@balloob balloob May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"*.ts": () => "tsc -p tsconfig.json",
"*.ts": () => "tsc -p tsconfig.json --noEmit",

Copy link
Copy Markdown
Member Author

@bramkragten bramkragten May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is already in our tsconfig right?

"*.{js,ts}": "eslint --fix",
"!(/translations)*.{js,ts,json,css,md,html}": "prettier --write",
};
13 changes: 1 addition & 12 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@
"gulp-zopfli-green": "^3.0.1",
"html-minifier": "^4.0.0",
"husky": "^1.3.1",
"lint-staged": "^8.1.5",
"lint-staged": "^10.5.4",
"lit-analyzer": "^1.2.1",
"lodash.template": "^4.5.0",
"magic-string": "^0.25.7",
Expand Down Expand Up @@ -250,17 +250,6 @@
"pre-commit": "lint-staged"
}
},
"lint-staged": {
"linters": {
"*.{js,ts,json,css,md}": [
"prettier --write",
"git add"
]
},
"ignore": [
"translations/**"
]
},
"prettier": {
"trailingComma": "es5",
"arrowParens": "always"
Expand Down
Loading