Dont require manifest for the overflow menu in integration card#9129
Merged
bramkragten merged 1 commit intodevfrom May 8, 2021
Merged
Dont require manifest for the overflow menu in integration card#9129bramkragten merged 1 commit intodevfrom
bramkragten merged 1 commit intodevfrom
Conversation
balloob
approved these changes
May 7, 2021
Member
|
I assumed we would always have the manifest and used it to speed up loading the page. btw, if there are domains that we don't have the manifest for, we should call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
If the integration is not loaded, we also don't have a manifest, not sure why we didn't show the menu when there was no manifest, @balloob ?
Fixes #9127
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: