Skip to content

Dont require manifest for the overflow menu in integration card#9129

Merged
bramkragten merged 1 commit intodevfrom
integration-manifest
May 8, 2021
Merged

Dont require manifest for the overflow menu in integration card#9129
bramkragten merged 1 commit intodevfrom
integration-manifest

Conversation

@bramkragten
Copy link
Copy Markdown
Member

Proposed change

If the integration is not loaded, we also don't have a manifest, not sure why we didn't show the menu when there was no manifest, @balloob ?

Fixes #9127

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob
Copy link
Copy Markdown
Member

balloob commented May 7, 2021

I assumed we would always have the manifest and used it to speed up loading the page.

btw, if there are domains that we don't have the manifest for, we should call HaConfigIntegrations._fetchManifest(domain)

@bramkragten bramkragten merged commit 88dc65b into dev May 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the integration-manifest branch May 8, 2021 11:08
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not able to delete or disable integration from UI when integration is not loaded

3 participants