Skip to content

Use hass-tabs-subpage-data-table for supervisor snapshots#9103

Merged
bramkragten merged 10 commits intodevfrom
snapshot-table
May 10, 2021
Merged

Use hass-tabs-subpage-data-table for supervisor snapshots#9103
bramkragten merged 10 commits intodevfrom
snapshot-table

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented May 5, 2021

Breaking change

Proposed change

Rewrites the Supervisor -> Snapshots tab to use data table
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added the Supervisor Related to the supervisor panel label May 5, 2021
@ludeeus ludeeus changed the title data Use hass-tabs-subpage-data-table for supervisor snapshots May 5, 2021
@balloob
Copy link
Copy Markdown
Member

balloob commented May 7, 2021

Out of scope for this PR, but wish we could do better than just "Partial". Things like "Almond add-on" etc.

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented May 7, 2021

For the "type" you mean?
If that information is available (without doing a call for each snapshot), i think having it as secondary text under the name is better

class HassioCreateSnapshotDialog extends LitElement {
@property({ attribute: false }) public hass!: HomeAssistant;

@internalProperty() private _snapshotName = "";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@internalProperty() private _snapshotName = "";
@state() private _snapshotName = "";

CSSResult,
customElement,
html,
internalProperty,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
internalProperty,
state,

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented May 10, 2021

If that information is available (without doing a call for each snapshot), i think having it as secondary text under the name is better

That information is currently not present, but I will do a follow up to both SU and frontend to expose and change that later

@bramkragten bramkragten merged commit 6dc7e85 into dev May 10, 2021
@bramkragten bramkragten deleted the snapshot-table branch May 10, 2021 16:17
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed Supervisor Related to the supervisor panel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants