Use hass-tabs-subpage-data-table for supervisor snapshots#9103
Merged
bramkragten merged 10 commits intodevfrom May 10, 2021
Merged
Use hass-tabs-subpage-data-table for supervisor snapshots#9103bramkragten merged 10 commits intodevfrom
bramkragten merged 10 commits intodevfrom
Conversation
bramkragten
reviewed
May 5, 2021
bramkragten
reviewed
May 5, 2021
bramkragten
reviewed
May 5, 2021
bramkragten
reviewed
May 5, 2021
bramkragten
reviewed
May 5, 2021
bramkragten
reviewed
May 5, 2021
bramkragten
reviewed
May 5, 2021
bramkragten
reviewed
May 5, 2021
bramkragten
reviewed
May 5, 2021
bramkragten
reviewed
May 5, 2021
bramkragten
reviewed
May 5, 2021
bramkragten
reviewed
May 7, 2021
bramkragten
reviewed
May 7, 2021
bramkragten
reviewed
May 7, 2021
bramkragten
reviewed
May 7, 2021
bramkragten
reviewed
May 7, 2021
bramkragten
reviewed
May 7, 2021
bramkragten
reviewed
May 7, 2021
bramkragten
reviewed
May 7, 2021
bramkragten
reviewed
May 7, 2021
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Member
|
Out of scope for this PR, but wish we could do better than just "Partial". Things like "Almond add-on" etc. |
Member
Author
|
For the "type" you mean? |
bramkragten
reviewed
May 8, 2021
| class HassioCreateSnapshotDialog extends LitElement { | ||
| @property({ attribute: false }) public hass!: HomeAssistant; | ||
|
|
||
| @internalProperty() private _snapshotName = ""; |
Member
There was a problem hiding this comment.
Suggested change
| @internalProperty() private _snapshotName = ""; | |
| @state() private _snapshotName = ""; |
bramkragten
reviewed
May 8, 2021
| CSSResult, | ||
| customElement, | ||
| html, | ||
| internalProperty, |
Member
There was a problem hiding this comment.
Suggested change
| internalProperty, | |
| state, |
Member
Author
That information is currently not present, but I will do a follow up to both SU and frontend to expose and change that later |
bramkragten
approved these changes
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Rewrites the Supervisor -> Snapshots tab to use data table

Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: