Detect and format timestamp attributes#9074
Merged
spacegaier merged 12 commits intohome-assistant:devfrom May 25, 2021
Merged
Conversation
bramkragten
reviewed
May 2, 2021
spacegaier
commented
May 2, 2021
bramkragten
reviewed
May 24, 2021
bramkragten
reviewed
May 24, 2021
bramkragten
approved these changes
May 24, 2021
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
… attr-timestamp-formatting
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
May 25, 2021
9 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Ensures that timestamps in more-info popus for attributes are properly formatted.
One point to discuss:
The RegExp I use also matches pure dates without a time element (but not the other way around) => should I add a second RegExp that then checks if it is a pure date and then we callformatDaterather thanformatDateTimeWithSecondsas I do currently?Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: