Close new automation dialog before moving to next step#9071
Merged
bramkragten merged 3 commits intodevfrom May 8, 2021
Merged
Conversation
balloob
commented
May 2, 2021
| } | ||
|
|
||
| public closeDialog(): void { | ||
| public async closeDialog(): Promise<void> { |
Member
There was a problem hiding this comment.
Use implements HassDialog and you'll get an error now :-)
balloob
commented
May 2, 2021
|
|
||
| public closeDialog(): void { | ||
| public async closeDialog(): Promise<void> { | ||
| if (!this._opened) { |
Member
Author
There was a problem hiding this comment.
Without this guard, it would fire twice because of the @closed event listener on <ha-dialog>
bramkragten
approved these changes
May 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
There was a race condition that prevented the new automation dialog from being cleaned up from the history. This caused users to get stuck because pressing the back arrow on the new automation would send you back to the dialog, which you can't close on mobile.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: