Skip to content

Add "subscribed to log" message on Z-Wave JS log subscription#9062

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
cgarwood:zjs_log_sub_msg
May 1, 2021
Merged

Add "subscribed to log" message on Z-Wave JS log subscription#9062
bramkragten merged 1 commit intohome-assistant:devfrom
cgarwood:zjs_log_sub_msg

Conversation

@cgarwood
Copy link
Copy Markdown
Member

Proposed change

When opening the Z-Wave JS Log pane it wasn't clear that it automatically subscribed to logs, as it could be a while before the first log message is received. This prints a message at the top of the log textarea on subscription to let the user know.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 7b8cb16 into home-assistant:dev May 1, 2021
@cgarwood cgarwood deleted the zjs_log_sub_msg branch May 1, 2021 13:17
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants