Skip to content

Check if temperature available in forecast#9055

Merged
balloob merged 1 commit intodevfrom
weather-forecast
Apr 30, 2021
Merged

Check if temperature available in forecast#9055
balloob merged 1 commit intodevfrom
weather-forecast

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Apr 30, 2021

Proposed change

Fixes #9047

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added this to the 2021.5.0 milestone Apr 30, 2021
@spacegaier
Copy link
Copy Markdown
Member

Should we perhaps show something like "-" to indicate that there is no value and prevent it from looking like a rendering issue / bug?

@bramkragten
Copy link
Copy Markdown
Member Author

I don't think it looks like a rendering error, we still reserve the space for it

@balloob balloob merged commit df22fd0 into dev Apr 30, 2021
@balloob balloob deleted the weather-forecast branch April 30, 2021 18:34
@bramkragten bramkragten mentioned this pull request Apr 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weather card displays null temperature values as 0º / misaligned

4 participants