Skip to content

Move ZHA config panel section translations to backend #9018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 1 commit into from
Apr 30, 2021
Merged

Move ZHA config panel section translations to backend #9018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/data/translation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export type TranslationCategory =
| "title"
| "state"
| "config"
| "config_panel"
| "options"
| "device_automation"
| "mfa_setup"
Expand Down
8 changes: 4 additions & 4 deletions src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ class ZHAConfigDashboard extends LitElement {
protected firstUpdated(changedProperties: PropertyValues): void {
super.firstUpdated(changedProperties);
if (this.hass) {
this.hass.loadBackendTranslation("config_panel", "zha", false);
this._fetchConfiguration();
}
}
Expand Down Expand Up @@ -108,7 +109,7 @@ class ZHAConfigDashboard extends LitElement {
? Object.entries(this._configuration.schemas).map(
([section, schema]) => html` <ha-card
header=${this.hass.localize(
`ui.panel.config.zha.configuration_page.${section}.title`
`component.zha.config_panel.${section}.title`
)}
>
<div class="card-content">
Expand Down Expand Up @@ -164,9 +165,8 @@ class ZHAConfigDashboard extends LitElement {
private _computeLabelCallback(localize, section: string) {
// Returns a callback for ha-form to calculate labels per schema object
return (schema) =>
localize(
`ui.panel.config.zha.configuration_page.${section}.${schema.name}`
) || schema.name;
localize(`component.zha.config_panel.${section}.${schema.name}`) ||
schema.name;
}

static get styles(): CSSResultArray {
Expand Down
7 changes: 1 addition & 6 deletions src/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2379,12 +2379,7 @@
},
"configuration_page": {
"shortcuts_title": "Shortcuts",
"update_button": "Update Configuration",
"zha_options": {
"title": "Global Options",
"enable_identify_on_join": "Enable identify effect when devices join the network",
"default_light_transition": "Default light transition time (seconds)"
}
"update_button": "Update Configuration"
},
"add_device_page": {
"spinner": "Searching for ZHA Zigbee devices...",
Expand Down