Reconfigure ZHA device take 2#8990
Merged
bramkragten merged 10 commits intohome-assistant:devfrom Apr 28, 2021
Merged
Conversation
Contributor
Author
|
@bramkragten right now I am kind of hacking _eventCount because when map properties change they don't appear to actually cause re-rendering. I am assuming there is a better way to do this? |
21 tasks
bramkragten
reviewed
Apr 26, 2021
bramkragten
reviewed
Apr 26, 2021
bramkragten
reviewed
Apr 27, 2021
bramkragten
reviewed
Apr 27, 2021
bramkragten
reviewed
Apr 27, 2021
bramkragten
reviewed
Apr 27, 2021
bramkragten
approved these changes
Apr 27, 2021
…ha-reconfigure-device.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl>
…ha-reconfigure-device.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl>
…ha-reconfigure-device.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Apr 28, 2021
Comment on lines
+81
to
+83
| this.hass.localize(`ui.dialogs.zha_reconfigure_device.heading`) + | ||
| ": " + | ||
| (this._params?.device.user_given_name || this._params?.device.name) |
Member
There was a problem hiding this comment.
${this.hass.localize(ui.dialogs.zha_reconfigure_device.heading)}: ${(this._params?.device.user_given_name || this._params?.device.name)}
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR enhances the new reconfigure device dialog for ZHA devices. The log relaying has been removed and it has been replaced by a more user friendly dialog.
reconfigure4.mov
REQUIRES home-assistant/core#49672
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: