Skip to content

Reconfigure ZHA device take 2#8990

Merged
bramkragten merged 10 commits intohome-assistant:devfrom
dmulcahey:dm/zha-reconfigure-device-phase-2
Apr 28, 2021
Merged

Reconfigure ZHA device take 2#8990
bramkragten merged 10 commits intohome-assistant:devfrom
dmulcahey:dm/zha-reconfigure-device-phase-2

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

@dmulcahey dmulcahey commented Apr 25, 2021

Proposed change

This PR enhances the new reconfigure device dialog for ZHA devices. The log relaying has been removed and it has been replaced by a more user friendly dialog.

reconfigure4.mov

REQUIRES home-assistant/core#49672

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@dmulcahey dmulcahey changed the title Dm/zha reconfigure device phase 2 Reconfigure ZHA device take 2 Apr 25, 2021
@dmulcahey
Copy link
Copy Markdown
Contributor Author

@bramkragten right now I am kind of hacking _eventCount because when map properties change they don't appear to actually cause re-rendering. I am assuming there is a better way to do this?

@dmulcahey dmulcahey marked this pull request as ready for review April 25, 2021 18:45
dmulcahey and others added 4 commits April 27, 2021 20:05
…ha-reconfigure-device.ts

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
…ha-reconfigure-device.ts

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
…ha-reconfigure-device.ts

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@bramkragten bramkragten merged commit 9690434 into home-assistant:dev Apr 28, 2021
Comment on lines +81 to +83
this.hass.localize(`ui.dialogs.zha_reconfigure_device.heading`) +
": " +
(this._params?.device.user_given_name || this._params?.device.name)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${this.hass.localize(ui.dialogs.zha_reconfigure_device.heading)}: ${(this._params?.device.user_given_name || this._params?.device.name)}

@balloob balloob mentioned this pull request Apr 28, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants