Skip to content

Use translations for config entry reason#8981

Merged
bramkragten merged 1 commit intodevfrom
integration-card-translations
Apr 26, 2021
Merged

Use translations for config entry reason#8981
bramkragten merged 1 commit intodevfrom
integration-card-translations

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 24, 2021

Breaking change

Proposed change

This will leverage existing error translations from config flows to render the Config Entry Not Ready reasons. We will fallback to the key if it's not translated.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 24e202a into dev Apr 26, 2021
@bramkragten bramkragten deleted the integration-card-translations branch April 26, 2021 15:50
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants