Ensure 0 does not get formatted to empty string#8971
Merged
bramkragten merged 2 commits intohome-assistant:devfrom Apr 23, 2021
Merged
Ensure 0 does not get formatted to empty string#8971bramkragten merged 2 commits intohome-assistant:devfrom
bramkragten merged 2 commits intohome-assistant:devfrom
Conversation
Member
Author
|
@joshmcrty Are there use cases I am missing where the empty string was by design returned from the formatting logic? |
bramkragten
approved these changes
Apr 23, 2021
Contributor
|
@spacegaier I don't remember now why I added that check in the return statement. At some point there may have been a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Currently a zero gets formatted to an empty string for number format "none". That should not happen as none means input = output value during formatting.
numis already ensured to bestringornumberin the function so no need to check for falsy during thereturnstatement (I think?).Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: