Skip to content

Fix rendering of a choose without any action taken#8952

Merged
bramkragten merged 1 commit intodevfrom
fix-choose-no-action
Apr 22, 2021
Merged

Fix rendering of a choose without any action taken#8952
bramkragten merged 1 commit intodevfrom
fix-choose-no-action

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 19, 2021

Breaking change

Proposed change

When a choose trace node has no result, it means none of the tested conditions were positive and no default was provided.

It will now render it as no action taken:

image

Fixes home-assistant/core#49380

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 5f78f18 into dev Apr 22, 2021
@bramkragten bramkragten deleted the fix-choose-no-action branch April 22, 2021 19:01
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automation Trace reports a non-existent error.

3 participants