Skip to content

Don't do migration of service data in public prop#8949

Merged
balloob merged 1 commit intodevfrom
dont-update-value-on-migration
Apr 26, 2021
Merged

Don't do migration of service data in public prop#8949
balloob merged 1 commit intodevfrom
dont-update-value-on-migration

Conversation

@bramkragten
Copy link
Copy Markdown
Member

Fixes #8879

Proposed change

Because we changed the public value property, every time an upgrade came from the parent component we would migrate it again and do too much work.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit 7e0522c into dev Apr 26, 2021
@balloob balloob deleted the dont-update-value-on-migration branch April 26, 2021 21:52
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI crashes when entering automations

3 participants