Skip to content

Allow falsey values for attribute value in a picture-elements card element. #8943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 3 commits into from
Apr 19, 2021
Merged

Allow falsey values for attribute value in a picture-elements card element. #8943

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e76db20
Allow falsey values for attribute value.
boralyl Apr 18, 2021
d846e9d
Check if attribute exists in state instead of undefined.
boralyl Apr 19, 2021
3aadf06
Fix conditional check
boralyl Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/panels/lovelace/elements/hui-state-label-element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class HuiStateLabelElement extends LitElement implements LovelaceElement {

if (
this._config.attribute &&
!stateObj.attributes[this._config.attribute]
!this._config.attribute in stateObj.attributes
Comment thread
boralyl marked this conversation as resolved.
Outdated
) {
return html`
<hui-warning-element
Expand Down