Load and subscribe to backend translations #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
emlove
force-pushed
the
backend-translations
branch
from
66c80b3 to
6b9a3db
Compare
emlove
changed the title
balloob
approved these changes
Mar 1, 2018
OttoWinter
reviewed
Mar 10, 2018
src/home-assistant.html
Outdated
| @@ -122,10 +122,10 @@ | |||
| loadBackendTranslations() { | |||
| if (!this.hass.language) return; | |||
There was a problem hiding this comment.
I think you need to change this to selectedLanguage too. See home-assistant/core#13035, we're requesting /api/translations/null on startup.
if (!this.hass. selectedLanguage) return;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the frontend to fetch and listen for updates to backend-defined translations. The intention here is that platforms will register platform-specific strings (configurator prompts, custom sensor states, etc.), which the frontend will load dynamically from the backend.
Backend PR: home-assistant/core#12453