Make error optional in connection lost service check#8937
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Apr 20, 2021
Merged
Make error optional in connection lost service check#8937bramkragten merged 1 commit intohome-assistant:devfrom
bramkragten merged 1 commit intohome-assistant:devfrom
Conversation
9 tasks
bdraco
commented
Apr 18, 2021
spacegaier
reviewed
Apr 19, 2021
Member
|
Oh shit, I now see we already threw the error before, after showing the toast... so this PR is not needed 🙈 Sorry! My bad... 🤦 The comment by @spacegaier should be addressed btw... |
bdraco
force-pushed
the
stop_restart_tweaks
branch
from
e517f4c to
6389c82
Compare
bdraco
changed the title
bramkragten
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Make error optional in connection lost service check
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: