Skip to content

Do not vertically align integration icon#8934

Merged
balloob merged 1 commit intodevfrom
center-header-info-only
Apr 17, 2021
Merged

Do not vertically align integration icon#8934
balloob merged 1 commit intodevfrom
center-header-info-only

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 17, 2021

Breaking change

Proposed change

Keep the icon always at the top. Still make sure that if the label is only 1 line, it is centered compared to the icon.

Before:
image

After:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit 982ab93 into dev Apr 17, 2021
@balloob balloob deleted the center-header-info-only branch April 17, 2021 06:16
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants