Skip to content

Added missing <ul> to beta join dialog#8927

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:missing-beta-join-ul
Apr 16, 2021
Merged

Added missing <ul> to beta join dialog#8927
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:missing-beta-join-ul

Conversation

@spacegaier
Copy link
Copy Markdown
Member

@spacegaier spacegaier commented Apr 16, 2021

Breaking change

Proposed change

The bullet point list is missing the surrounding <ul> tag.

Before:
image

Note: The swapped button text has already been addressed by another merged PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit a09b206 into home-assistant:dev Apr 16, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants