Skip to content

Set standard name for Cancel button, to align translations#8914

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
CarlosGS:patch-1
Apr 14, 2021
Merged

Set standard name for Cancel button, to align translations#8914
bramkragten merged 2 commits intohome-assistant:devfrom
CarlosGS:patch-1

Conversation

@CarlosGS
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

From a brief discussion in "Lokalise->Polymer frontend" for ui::panel::lovelace::editor::save_config::cancel

Screenshot_20210414_092008

The original english text for the buttons is "Never mind" and "Take control".

Desired action for "Never mind" is to Cancel and close the prompt, however:

  • Spanish translation was "No importa", in context "Sure, I don't mind" (!!)
  • Default french translation was cheesy: "Oublie ce que j'ai dit, c'est pas grave" / "Forget what I just said, it is not important" 😄

From Dannie Rothman at Lokalise:

I Agree, Danish, Swedish and Norwegian also ends up as something like "Forget it" or "Not really" - i changed the Danish version to something matching "Cancel"

Proposed PR change is "Never mind" becoming "Cancel" to make it more intuitive and standard UI, aligned across languages.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @CarlosGS,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@CarlosGS
Copy link
Copy Markdown
Contributor Author

More examples of the issue:

Yesterday I changed the spanish translation to "Mejor no", which is the closest expression I could find to accurately replace "Never mind" in the same context. But the edit has been reverted to "No importa" without realising of the context. This confusion can easily happen with any language, hence the suggestion to use "Cancel".

Latin spanish uses "Olvídalo" / "Forget about it", which is OK, but still feels a bit orthopedic.

Copy link
Copy Markdown
Member

@spacegaier spacegaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid point 👍

Comment thread src/translations/en.json Outdated
"yaml_config": "To help you start here is the current config of this dashboard:",
"empty_config": "Start with an empty dashboard",
"cancel": "Never mind",
"cancel": "Cancel",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have common translation for cancel: ui.common.cancel

@CarlosGS CarlosGS reopened this Apr 14, 2021
@CarlosGS
Copy link
Copy Markdown
Contributor Author

There you go, thanks for the tip @bramkragten! :)

PS: Sorry for the PR close/reopen noise.

@bramkragten bramkragten merged commit c53575a into home-assistant:dev Apr 14, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants