Set standard name for Cancel button, to align translations#8914
Merged
bramkragten merged 2 commits intohome-assistant:devfrom Apr 14, 2021
Merged
Set standard name for Cancel button, to align translations#8914bramkragten merged 2 commits intohome-assistant:devfrom
bramkragten merged 2 commits intohome-assistant:devfrom
Conversation
Contributor
Contributor
Author
|
More examples of the issue: Yesterday I changed the spanish translation to "Mejor no", which is the closest expression I could find to accurately replace "Never mind" in the same context. But the edit has been reverted to "No importa" without realising of the context. This confusion can easily happen with any language, hence the suggestion to use "Cancel". Latin spanish uses "Olvídalo" / "Forget about it", which is OK, but still feels a bit orthopedic. |
bramkragten
reviewed
Apr 14, 2021
| "yaml_config": "To help you start here is the current config of this dashboard:", | ||
| "empty_config": "Start with an empty dashboard", | ||
| "cancel": "Never mind", | ||
| "cancel": "Cancel", |
Member
There was a problem hiding this comment.
We have common translation for cancel: ui.common.cancel
Contributor
Author
|
There you go, thanks for the tip @bramkragten! :) PS: Sorry for the PR close/reopen noise. |
bramkragten
approved these changes
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
From a brief discussion in "Lokalise->Polymer frontend" for
ui::panel::lovelace::editor::save_config::cancelThe original english text for the buttons is "Never mind" and "Take control".
Desired action for "Never mind" is to Cancel and close the prompt, however:
From Dannie Rothman at Lokalise:
Proposed PR change is "Never mind" becoming "Cancel" to make it more intuitive and standard UI, aligned across languages.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: