Skip to content

Unsubscribe when dismissing during wrap up#8909

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
bdraco:fix_long_startup_wrap_dismiss
Apr 13, 2021
Merged

Unsubscribe when dismissing during wrap up#8909
bramkragten merged 1 commit intohome-assistant:devfrom
bdraco:fix_long_startup_wrap_dismiss

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 13, 2021

Proposed change

Unsubscribe when dismissing during wrap up

If wrap up takes a while, the toast could reappear after first dismissed because it was not unsubscribed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 445ae15 into home-assistant:dev Apr 13, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants