Skip to content

Fix time selector + base am/pm on user language#8908

Merged
bramkragten merged 4 commits intodevfrom
time-selector
Apr 14, 2021
Merged

Fix time selector + base am/pm on user language#8908
bramkragten merged 4 commits intodevfrom
time-selector

Conversation

@bramkragten
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Comment thread src/components/ha-selector/ha-selector-time.ts Outdated
});

protected render() {
const useAMPM = this._useAmPm(this.hass.locale.language);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we memoize this ?

Copy link
Copy Markdown
Member Author

@bramkragten bramkragten Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is 😄
image

Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@bramkragten bramkragten merged commit 193016a into dev Apr 14, 2021
@bramkragten bramkragten deleted the time-selector branch April 14, 2021 19:51
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants