Skip to content

Fix saving entities of the device in scene editor#8884

Merged
bramkragten merged 3 commits intohome-assistant:devfrom
dabku:scene-entity-pick
Apr 12, 2021
Merged

Fix saving entities of the device in scene editor#8884
bramkragten merged 3 commits intohome-assistant:devfrom
dabku:scene-entity-pick

Conversation

@dabku
Copy link
Copy Markdown
Contributor

@dabku dabku commented Apr 9, 2021

Breaking change

Proposed change

If you pick an entity (not a device) in the scene editor that does not belong to the device, the device will be added. There is no indication that the rest of the entities from this device won't be saved even if the state was manipulated in the editor. To provide a way to save the state of just picked entity and be able to change the rest of the device, I propose to add an entity to the scene every time a device's entity is clicked (to show more info).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Copy Markdown
Member

The fix should be adding all entities of the device when the entity is added.

@dabku
Copy link
Copy Markdown
Contributor Author

dabku commented Apr 11, 2021

The fix should be adding all entities of the device when the entity is added.

Logic was updated. It will now add a device with all the entities.

@bramkragten bramkragten merged commit ea60f70 into home-assistant:dev Apr 12, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants