Fix saving entities of the device in scene editor#8884
Merged
bramkragten merged 3 commits intohome-assistant:devfrom Apr 12, 2021
Merged
Fix saving entities of the device in scene editor#8884bramkragten merged 3 commits intohome-assistant:devfrom
bramkragten merged 3 commits intohome-assistant:devfrom
Conversation
Member
|
The fix should be adding all entities of the device when the entity is added. |
Contributor
Author
Logic was updated. It will now add a device with all the entities. |
bramkragten
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
If you pick an entity (not a device) in the scene editor that does not belong to the device, the device will be added. There is no indication that the rest of the entities from this device won't be saved even if the state was manipulated in the editor. To provide a way to save the state of just picked entity and be able to change the rest of the device, I propose to add an entity to the scene every time a device's entity is clicked (to show more info).
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: