Conversation
bramkragten
changed the title
bramkragten
force-pushed
the
update-lit-to-next
branch
from
cf06e51 to
5f3148a
Compare
bramkragten
changed the title
ludeeus
approved these changes
May 6, 2021
balloob
approved these changes
May 7, 2021
balloob
reviewed
May 14, 2021
| public connectedCallback() { | ||
| super.connectedCallback(); | ||
| if (!this.shadowRoot) { | ||
| this.attachShadow({ mode: "open" }); |
Member
There was a problem hiding this comment.
This didn't have a shadow root on purpose. <ha-markdown> is the one with shadow dom. This element was just to render the markdown.
This causes <ha-markdown> styling to not be applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This updates our code base to the new API of Lit 2.0 using the forward compatibility of lit-element 2.5 and lit-html 1.4
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: