Skip to content

Add units to Z-Wave JS Node Config inputs#8869

Merged
balloob merged 2 commits intohome-assistant:devfrom
cgarwood:zwjs_node_config_units
Apr 8, 2021
Merged

Add units to Z-Wave JS Node Config inputs#8869
balloob merged 2 commits intohome-assistant:devfrom
cgarwood:zwjs_node_config_units

Conversation

@cgarwood
Copy link
Copy Markdown
Member

@cgarwood cgarwood commented Apr 8, 2021

Proposed change

If a Z-Wave JS node configuration parameter provides a unit of measurement, show that on the input element.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit 87fe84b into home-assistant:dev Apr 8, 2021
@bramkragten bramkragten added this to the 2021.4.2 milestone Apr 9, 2021
bramkragten pushed a commit that referenced this pull request Apr 9, 2021
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZWave-JS device configuration items are missing units

4 participants