Skip to content

Fix spinner regression and remove unnecessary twoline config#8847

Merged
donkawechico merged 1 commit intodevfrom
fix-quick-bar-spinner
Apr 8, 2021
Merged

Fix spinner regression and remove unnecessary twoline config#8847
donkawechico merged 1 commit intodevfrom
fix-quick-bar-spinner

Conversation

@donkawechico
Copy link
Copy Markdown
Contributor

Proposed change

The recent command item labels feature had a bug that removed the progress spinner for long-running commands (e.g. Reload Automations).

This PR fixes the issue and removes an unnecessary two-line check in the command item renderer.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier spacegaier added this to the 2021.4.1 milestone Apr 7, 2021
@donkawechico donkawechico merged commit 2d15bd6 into dev Apr 8, 2021
@delete-merged-branch delete-merged-branch Bot deleted the fix-quick-bar-spinner branch April 8, 2021 04:18
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants