Do not use "media_play_pause" but atomic services instead#8845
Merged
spacegaier merged 1 commit intohome-assistant:devfrom Apr 8, 2021
Merged
Do not use "media_play_pause" but atomic services instead#8845spacegaier merged 1 commit intohome-assistant:devfrom
spacegaier merged 1 commit intohome-assistant:devfrom
Conversation
bramkragten
approved these changes
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Currently we are using the service
media_play_pauseto start media playback. Since there are however media players that do not support pausing, they do not have that service implemented and therefore the playback cannot be started.With this PR we now use the atomic
media_playinstead and pause viamedia_pauseif supported by the player.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: