Skip to content

Use number format setting for attribute rows#8844

Merged
spacegaier merged 4 commits intohome-assistant:devfrom
spacegaier:num-format-attribute
Apr 8, 2021
Merged

Use number format setting for attribute rows#8844
spacegaier merged 4 commits intohome-assistant:devfrom
spacegaier:num-format-attribute

Conversation

@spacegaier
Copy link
Copy Markdown
Member

@spacegaier spacegaier commented Apr 7, 2021

Breaking change

Proposed change

Rendered attributes in an Entities card did not adhere to the new number format setting.

The red values all share the same source, but the first one is an attribute row and the other two are a template sensor based on that attribute (frontend correctly handled those states already).
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier spacegaier added this to the 2021.4.1 milestone Apr 7, 2021
@spacegaier
Copy link
Copy Markdown
Member Author

@joshmcrty FYI in case you want to chime in

Comment thread src/panels/lovelace/special-rows/hui-attribute-row.ts Outdated
@spacegaier spacegaier merged commit c3f0932 into home-assistant:dev Apr 8, 2021
@spacegaier spacegaier deleted the num-format-attribute branch April 8, 2021 08:52
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants