Skip to content

Remove owner guard from analytics#8842

Merged
ludeeus merged 1 commit intodevfrom
remove-owner-guard
Apr 7, 2021
Merged

Remove owner guard from analytics#8842
ludeeus merged 1 commit intodevfrom
remove-owner-guard

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 7, 2021

Breaking change

Proposed change

This guard is not necessary. The config UI is only visible to admins and the backend API is also guarded for admins.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus merged commit e425d76 into dev Apr 7, 2021
@ludeeus ludeeus deleted the remove-owner-guard branch April 7, 2021 16:41
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2021
@bramkragten bramkragten added this to the 2021.4.1 milestone Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants