Add feedback dialog for ZHA device reconfiguration#8742
Merged
bramkragten merged 3 commits intohome-assistant:devfrom Mar 31, 2021
Merged
Add feedback dialog for ZHA device reconfiguration#8742bramkragten merged 3 commits intohome-assistant:devfrom
bramkragten merged 3 commits intohome-assistant:devfrom
Conversation
Contributor
Author
|
@bramkragten when you have a sec... I am struggling w/ something silly with this. The dialog works and shows for the first invocation. I have to refresh the page to make it work again after it is dismissed... What am I missing? |
bramkragten
reviewed
Mar 30, 2021
bramkragten
reviewed
Mar 30, 2021
bramkragten
reviewed
Mar 30, 2021
Comment on lines
+67
to
+73
| <paper-textarea | ||
| readonly | ||
| max-rows="10" | ||
| class="log" | ||
| value="${this._formattedEvents}" | ||
| > | ||
| </paper-textarea> |
Member
There was a problem hiding this comment.
Let's put these technical details inside an expansion-panel
Contributor
Author
There was a problem hiding this comment.
that's all this dialog is right now... I can do that once I devise a way to show this better graphically?
bramkragten
reviewed
Mar 30, 2021
bramkragten
reviewed
Mar 30, 2021
bramkragten
reviewed
Mar 30, 2021
Contributor
Author
|
@bramkragten backend PR merged |
bramkragten
approved these changes
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds support for visual feedback for ZHA device reconfiguration.
REQUIRES home-assistant/core#48447
reconfigure_device.mov
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: