Skip to content

Display cumulative setup seconds on the config info page#8720

Merged
bramkragten merged 5 commits intohome-assistant:devfrom
bdraco:integration_setup_time
Apr 27, 2021
Merged

Display cumulative setup seconds on the config info page#8720
bramkragten merged 5 commits intohome-assistant:devfrom
bdraco:integration_setup_time

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 25, 2021

Proposed change

Show users why their setup/startup is slow.

Screen Shot 2021-03-25 at 8 46 55 AM

Requires home-assistant/core#48274

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Comment thread src/panels/config/info/integrations-card.ts Outdated
@bdraco bdraco marked this pull request as ready for review March 29, 2021 02:06
Comment thread src/data/integration.ts Outdated
Copy link
Copy Markdown
Member

@spacegaier spacegaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/panels/config/info/integrations-card.ts Outdated
@bramkragten
Copy link
Copy Markdown
Member

bramkragten commented Apr 13, 2021

We should probably look at hiding some columns for mobile or folding the rows, as it already doesn't fit now, and we are adding another column.

Something like:

image

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 14, 2021

image

That looks good. 👍 I'll try to find an example in the frontend code base and replicate it. Marking this as a draft in the mean time since its too late here to make progress.

@bdraco bdraco marked this pull request as draft April 14, 2021 07:22
@bdraco bdraco force-pushed the integration_setup_time branch from 64aa667 to 378bd9d Compare April 23, 2021 05:15
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 26, 2021

I haven't found a modern example of hiding this in the codebase. There are some references to a narrow property, but I'm not sure what the preferred approach is here.

@bramkragten
Copy link
Copy Markdown
Member

Yes, we should use narrow, for the layout we probably wanna use flexbox.

I can push something if you want tomorrow?

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 27, 2021

Yes, we should use narrow, for the layout we probably wanna use flexbox.

I can push something if you want tomorrow?

That would be fantastic!

@bramkragten bramkragten marked this pull request as ready for review April 27, 2021 21:31
@bramkragten bramkragten merged commit 0c12586 into home-assistant:dev Apr 27, 2021
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 27, 2021

Thanks for the help getting this one done. 👏👍🎉

@balloob balloob mentioned this pull request Apr 28, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants