Skip to content

Check if Google Assistant is linked#8613

Merged
bramkragten merged 5 commits intodevfrom
googl-assistant-check
Mar 29, 2021
Merged

Check if Google Assistant is linked#8613
bramkragten merged 5 commits intodevfrom
googl-assistant-check

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Mar 10, 2021

Proposed change

Requires home-assistant/core#48260

Not linked:
image

Linked:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Comment thread src/translations/en.json Outdated
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

We also trigger a sync when people change their exposed entities. That is not covered by this PR yet.

Also thinking here, we now disable it when we get a 404, but maybe that should happen on the backend? We disable it until the user requests a Sync.

We also keep track of synced users in Google in the backend, wonder if we should pull in that data here?

bramkragten and others added 2 commits March 24, 2021 16:33
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@bramkragten bramkragten changed the title Check if Google Assistant is setup when enable Check if Google Assistant is linked Mar 24, 2021
@bramkragten bramkragten merged commit 66c30a5 into dev Mar 29, 2021
@bramkragten bramkragten deleted the googl-assistant-check branch March 29, 2021 17:27
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants