Skip to content

Handle reconnect while in raw edit#8500

Merged
bramkragten merged 1 commit intodevfrom
handle-reconnect-while-in-raw-edit
Mar 1, 2021
Merged

Handle reconnect while in raw edit#8500
bramkragten merged 1 commit intodevfrom
handle-reconnect-while-in-raw-edit

Conversation

@bramkragten
Copy link
Copy Markdown
Member

Proposed change

When we reconnected, we would always close the raw editor, causing you to lose all edits you did, this fixes that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added this to the 2021.3.0 milestone Mar 1, 2021
@bramkragten bramkragten requested a review from ludeeus March 1, 2021 15:28
@bramkragten bramkragten merged commit 5ff757a into dev Mar 1, 2021
@bramkragten bramkragten deleted the handle-reconnect-while-in-raw-edit branch March 1, 2021 15:55
@bramkragten bramkragten mentioned this pull request Mar 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants