Consistent blank before "%"#8366
Merged
bramkragten merged 4 commits intohome-assistant:devfrom Mar 7, 2021
Merged
Conversation
Member
|
This is going to be another argument 😄
|
Member
Author
Member
|
I'm ok with adding the space, was just mentioning that it could lead to another round of arguments :-) |
Member
Author
I am fine with arguing for consistency, so point them to me :) . I resolved the merge conflicts. Let me know if everything looks good. |
bramkragten
approved these changes
Mar 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Breaking change
Proposed change
Percent is basically a "unit", so we should consistently have a blank in front of it. In some areas we already do, in other not. With this PR it should now be (more) consistent.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: