Add support for custom_card component#831
Closed
c727 wants to merge 6 commits intohome-assistant:masterfrom
c727:custom_card
Closed
Add support for custom_card component#831c727 wants to merge 6 commits intohome-assistant:masterfrom c727:custom_card
c727 wants to merge 6 commits intohome-assistant:masterfrom
c727:custom_card
Conversation
4 tasks
Contributor
Author
|
What data is OK for stateObj.attributes? I'm sure don't allow me to store my config there... Should I create an API or are there some other solutions? Also, how would I share this data for all cards (more-info) instead of calling the API again? |
Contributor
Author
|
Frontend PR should be OK now, changed it to use custom_ui_xxx as Andrey suggested |
2 tasks
andrey-git
reviewed
Jan 30, 2018
| persistent_notification: 0, | ||
| plant: 3, | ||
| weather: 4, | ||
| custom_full_card: 0, |
Contributor
There was a problem hiding this comment.
Is there an agreement on the backend PR? If not - let's drop this line change for now
Contributor
Author
There was a problem hiding this comment.
You are right, I wanted to avoid merge conflicts in my first approach. Will submit a new PR
| this, 'HA-' + newData.cardType.toUpperCase() + '-CARD', | ||
| newData | ||
| ); | ||
| var cardType; |
Contributor
There was a problem hiding this comment.
Use let here and elsewhere in new code.
Contributor
Author
|
functionality is will be included in frontend entity registry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
custom_cardis a component to show any custom content on HA frontend likefloorplan or my state-cards 1 2 that currently have to hijack the card of another entity to show up on frontend.
config:
Backend-PR: home-assistant/core#11866