Skip to content

Visual alignment of automation and script more info dialogs#8234

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:alignment-more-info-auto-script
Jan 26, 2021
Merged

Visual alignment of automation and script more info dialogs#8234
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:alignment-more-info-auto-script

Conversation

@spacegaier
Copy link
Copy Markdown
Member

@spacegaier spacegaier commented Jan 25, 2021

Breaking change

Proposed change

Remove two inconsistencies:

  1. Script more info: "Last triggered" info was not separated into label on the left, value on the right. Fixed now.
  2. Automation more info: "Execute" button was on the right rather than in the middle as we do with all other more info dialogs that contain actions (counter, timer, etc.).

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Copy Markdown
Member

Got a screenshot?

@spacegaier
Copy link
Copy Markdown
Member Author

Got a screenshot?

There is not much to look at, but I updated the PR above.

@bramkragten bramkragten merged commit 0a09ec7 into home-assistant:dev Jan 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants