Skip to content

Use app header color as default selected tab color + allow styling#8227

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:app-header-bar-color
Jan 25, 2021
Merged

Use app header color as default selected tab color + allow styling#8227
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:app-header-bar-color

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

In the default theme, the issue is not visible, since the colors match "by accident". But this PR now ensures that if the user specified a dedicated header text color via --app-header-text-color the same one is used to mark the currently active tab by default. On top I added a variable --app-header-selection-bar-color so themes can adjust the color.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 748a05f into home-assistant:dev Jan 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2021
@spacegaier spacegaier deleted the app-header-bar-color branch February 3, 2021 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants