Prevent automation action row issue if event name gets cleared#8213
Merged
bramkragten merged 2 commits intohome-assistant:devfrom Jan 25, 2021
Merged
Prevent automation action row issue if event name gets cleared#8213bramkragten merged 2 commits intohome-assistant:devfrom
bramkragten merged 2 commits intohome-assistant:devfrom
Conversation
bramkragten
reviewed
Jan 25, 2021
src/panels/config/automation/action/types/ha-automation-action-event.ts
Outdated
Show resolved
Hide resolved
…-event.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
approved these changes
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Previously the default
handleChangeEvent()was used to react to changes in the "Event" input field. But as soon as it got empty, the property was removed from the action. Since however it is mandatory for the action row to know what type of action editor to show, the property needs to stay. Solved by calling "value-changed" ourself without property removal upon empty value.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: