Skip to content

Prevent automation action row issue if event name gets cleared#8213

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:issue-8059
Jan 25, 2021
Merged

Prevent automation action row issue if event name gets cleared#8213
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:issue-8059

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Previously the default handleChangeEvent() was used to react to changes in the "Event" input field. But as soon as it got empty, the property was removed from the action. Since however it is mandatory for the action row to know what type of action editor to show, the property needs to stay. Solved by calling "value-changed" ourself without property removal upon empty value.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

…-event.ts

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@bramkragten bramkragten merged commit cf43b26 into home-assistant:dev Jan 25, 2021
@spacegaier spacegaier deleted the issue-8059 branch January 25, 2021 19:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automation editor reverts to YAML mode on clearing some text fields

3 participants