Skip to content

Tweak UI handle-errors text message a bit#8211

Closed
spacegaier wants to merge 1 commit intohome-assistant:devfrom
spacegaier:handle-errors-text-quotes
Closed

Tweak UI handle-errors text message a bit#8211
spacegaier wants to merge 1 commit intohome-assistant:devfrom
spacegaier:handle-errors-text-quotes

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Those 4 double quotes always irked me, as well as the apostrophe followed by a double quote.

image

I changed three things:

  1. The expected type and the actual value are now put into round brackets. Makes it easier to read.
  2. If no value is provided, then the text now says so.
  3. Small wording changes for clarity and readability.

A few examples how it looks now:
image

image

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier
Copy link
Copy Markdown
Member Author

Will be covered by PR #8217 (includes proper translations).

@spacegaier spacegaier closed this Jan 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants