Make "button row" name optional to be consistent with "button card" and "buttons row"#8189
Merged
spacegaier merged 2 commits intohome-assistant:devfrom Jan 21, 2021
Merged
Conversation
bramkragten
approved these changes
Jan 21, 2021
Member
|
OK to merge after documentation PR made |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Not breaking, since officially no one should have been setting an entity yet for this row. If they were and did not specify an override icon until now, then the "hass:remote" icon that they had so far will be replaced by the entity icon.
Proposed change
Making the behavior of
buttonrow andbuttoncard consistent:nameis now optional and we use the entity friendly name if we have one. We also use the icon from it, if no override icon is provided.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: