Skip to content

Make "button row" name optional to be consistent with "button card" and "buttons row"#8189

Merged
spacegaier merged 2 commits intohome-assistant:devfrom
spacegaier:entities-button-row-name-opt
Jan 21, 2021
Merged

Make "button row" name optional to be consistent with "button card" and "buttons row"#8189
spacegaier merged 2 commits intohome-assistant:devfrom
spacegaier:entities-button-row-name-opt

Conversation

@spacegaier
Copy link
Copy Markdown
Member

@spacegaier spacegaier commented Jan 17, 2021

Breaking change

Not breaking, since officially no one should have been setting an entity yet for this row. If they were and did not specify an override icon until now, then the "hass:remote" icon that they had so far will be replaced by the entity icon.

Proposed change

Making the behavior of button row and button card consistent: name is now optional and we use the entity friendly name if we have one. We also use the icon from it, if no override icon is provided.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Copy Markdown
Member

OK to merge after documentation PR made

@spacegaier spacegaier merged commit 599dd81 into home-assistant:dev Jan 21, 2021
@spacegaier spacegaier deleted the entities-button-row-name-opt branch January 21, 2021 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants