Skip to content

Add error handling to action handling#8187

Merged
spacegaier merged 6 commits intohome-assistant:devfrom
spacegaier:handle_action_errors
Jan 21, 2021
Merged

Add error handling to action handling#8187
spacegaier merged 6 commits intohome-assistant:devfrom
spacegaier:handle_action_errors

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

To assist users with developing their dashboards (easily spot mistakes/issues) and also to properly react to wrong data at runtime, add error toasts to action handling.

I also moved one translation key "action_confirmation" into the new subgroup. I know that we usually try to prevent that, but this key was just recently added by me (12 days ago) so chances are that not too many languages contain it yet, so not so much double-effort, but I really think with the new translation key group it should be moved.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier spacegaier merged commit 9e99d15 into home-assistant:dev Jan 21, 2021
@spacegaier spacegaier deleted the handle_action_errors branch January 21, 2021 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants