Skip to content

Set sensible default tap_action (same logic as button row)#8186

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:entities-buttons-tap_action
Jan 21, 2021
Merged

Set sensible default tap_action (same logic as button row)#8186
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:entities-buttons-tap_action

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

The button row already had logic to determine a sensible default tap action. Now copied over to buttons row to prevent impossible toggles.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 136ebb5 into home-assistant:dev Jan 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants