Skip to content

Add minutes to hourly weather forecast time display#8182

Merged
spacegaier merged 5 commits intohome-assistant:devfrom
spacegaier:weather-hour-format
Jan 26, 2021
Merged

Add minutes to hourly weather forecast time display#8182
spacegaier merged 5 commits intohome-assistant:devfrom
spacegaier:weather-hour-format

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Might be subjective, but to me the hourly weather forecast looks weird. The numbers could easily indicate day of the month as well. So adding the minutes makes it clear and has no impact on the size, since we are not getting wider as the forecast icon already is.

Before:
image

image

After:
image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@spacegaier spacegaier merged commit 0dd9b21 into home-assistant:dev Jan 26, 2021
@spacegaier spacegaier deleted the weather-hour-format branch January 26, 2021 15:14
@bramkragten bramkragten mentioned this pull request Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants