Add minutes to hourly weather forecast time display#8182
Merged
spacegaier merged 5 commits intohome-assistant:devfrom Jan 26, 2021
Merged
Add minutes to hourly weather forecast time display#8182spacegaier merged 5 commits intohome-assistant:devfrom
spacegaier merged 5 commits intohome-assistant:devfrom
Conversation
bramkragten
reviewed
Jan 21, 2021
bramkragten
reviewed
Jan 21, 2021
bramkragten
reviewed
Jan 21, 2021
bramkragten
reviewed
Jan 21, 2021
9 tasks
bramkragten
reviewed
Jan 25, 2021
bramkragten
approved these changes
Jan 25, 2021
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Might be subjective, but to me the hourly weather forecast looks weird. The numbers could easily indicate day of the month as well. So adding the minutes makes it clear and has no impact on the size, since we are not getting wider as the forecast icon already is.
Before:

After:

Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: