Skip to content

Add navigation to dashboard & resources to lovelace editor + icons#8156

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:issue-5172
Jan 27, 2021
Merged

Add navigation to dashboard & resources to lovelace editor + icons#8156
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:issue-5172

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Navigation options + icons as proposed in the linked FR.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@Misiu
Copy link
Copy Markdown
Contributor

Misiu commented Jan 14, 2021

@spacegaier the first element on the list doesn't have an icon.
Maybe the view-list icon?
image

@spacegaier
Copy link
Copy Markdown
Member Author

I know, because I did not find a god one on my first glance. Your proposal looks quit similar to the next two which feels confusing. I would prefer something more distinct like this:

image

@bramkragten bramkragten merged commit 5f003cc into home-assistant:dev Jan 27, 2021
@bramkragten bramkragten mentioned this pull request Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dashboards/resources to Lovelace menu in Configure UI mode

4 participants