Skip to content

Change supportsStop to supportsStopTilt#8153

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
iMicknl:fix/stop_tilt_controls
Jan 14, 2021
Merged

Change supportsStop to supportsStopTilt#8153
bramkragten merged 1 commit intohome-assistant:devfrom
iMicknl:fix/stop_tilt_controls

Conversation

@iMicknl
Copy link
Copy Markdown
Member

@iMicknl iMicknl commented Jan 13, 2021

Proposed change

Since a recent update, the controls for a cover with only tilt features are partially broken. The stop button is not present anymore since a recent update. This is due to the fact that front-end checks for supportsStop instead of supportsStopTilt. This is the wrong feature from supported_features, since it is not related to the tilt controls.

Before:
Screen Shot 2021-01-13 at 18 23 59

After:
Screen Shot 2021-01-13 at 18 38 48

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Copy Markdown
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bramkragten bramkragten merged commit fd2df92 into home-assistant:dev Jan 14, 2021
@iMicknl iMicknl deleted the fix/stop_tilt_controls branch January 14, 2021 11:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MQTT Cover - Tilt Controls missing (upgrade to 118.1) Cover card open_cover_tilt and close_cover_tilt not available

3 participants