Skip to content

Clear entity ID during automation duplication#8140

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:issue-7315
Jan 13, 2021
Merged

Clear entity ID during automation duplication#8140
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:issue-7315

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

During automation duplication, the entity ID was not reset which meant that for the unsaved new automation, we still internally had the old stateObj during rendering and allowed the user to enable/disable and execute the old base automation.

With this PR we now set the entity ID back to undefined and the UI reacts accordingly.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 131a7f3 into home-assistant:dev Jan 13, 2021
@spacegaier spacegaier deleted the issue-7315 branch January 13, 2021 19:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automation Duplicate, clicking enable/disable button before Save alters the original only

3 participants