Skip to content

Add Core to supervisor/system#8123

Merged
bramkragten merged 7 commits intodevfrom
supervisor-system
Jan 11, 2021
Merged

Add Core to supervisor/system#8123
bramkragten merged 7 commits intodevfrom
supervisor-system

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Jan 10, 2021

Breaking change

Proposed change

Add a Core card to supervisor/system.
With both core and supervisor using calver, the confusion continues, hopefully, this will make things clearer.
Action buttons have also been prefixed, like "Supervisor restart"

The metrics card is removed and the metrics are inserted at the bottom of their respective cards.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

image

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • [:joy:] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added the Supervisor Related to the supervisor panel label Jan 10, 2021
@bramkragten
Copy link
Copy Markdown
Member

Shouldnt core be the first card?

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Jan 11, 2021

It's the Supervisor panel, IMO all other "sections" are secondary information

@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 11, 2021

I agree with Bram. It feels more logical to have Core -> Supervisor -> Host (or Host -> Supervisor -> Core) in order of the way they are stacked.

(BTW, freaking nice addition, will help to resolve versioning understanding issues).

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Jan 11, 2021

Core - SU - host
image

Host - SU - Core
image

@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 11, 2021

For me, personally, either works. The last one (host first) feels more focused on the Supervisor panel maybe, so that might be better.

@bramkragten
Copy link
Copy Markdown
Member

bramkragten commented Jan 11, 2021

Personally, I would still prefer core first, but I can also live with this.

I'm afraid people will reboot the host more now.

@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 11, 2021

@bramkragten Haha that is actually a valid concern 😓

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Jan 11, 2021

reordered, and added confirmation dialogs to core/su restart

@bramkragten
Copy link
Copy Markdown
Member

One last nitpicks, can we change the wording on the buttons?

Core Restart -> Restart Core
Host Reboot -> Reboot Host

etc

@bramkragten bramkragten merged commit b148328 into dev Jan 11, 2021
@bramkragten bramkragten deleted the supervisor-system branch January 11, 2021 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed Supervisor Related to the supervisor panel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants