Skip to content

Adjust / theme entity marker background color#8116

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:entity-marker-color
Jan 13, 2021
Merged

Adjust / theme entity marker background color#8116
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:entity-marker-color

Conversation

@spacegaier
Copy link
Copy Markdown
Member

@spacegaier spacegaier commented Jan 8, 2021

Breaking change

Proposed change

Previously the entity marker color was hardcoded to white. Now it is following the theme variables (same one that is used in the sidebar for the user avatar if no image is uploaded). Makes the markers less jarring in the dark theme (previously white on dark gray map) and stand out more in the light theme (white on white map).

grafik

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

<style include="iron-positioning"></style>
<style>
.marker {
vertical-align: top;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed since can never take effect due to display: block;

@bramkragten bramkragten merged commit 28ca1a5 into home-assistant:dev Jan 13, 2021
@spacegaier spacegaier deleted the entity-marker-color branch January 13, 2021 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants