Adjust / theme entity marker background color#8116
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Jan 13, 2021
Merged
Adjust / theme entity marker background color#8116bramkragten merged 1 commit intohome-assistant:devfrom
bramkragten merged 1 commit intohome-assistant:devfrom
Conversation
spacegaier
commented
Jan 8, 2021
| <style include="iron-positioning"></style> | ||
| <style> | ||
| .marker { | ||
| vertical-align: top; |
Member
Author
There was a problem hiding this comment.
Removed since can never take effect due to display: block;
bramkragten
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Previously the entity marker color was hardcoded to white. Now it is following the theme variables (same one that is used in the sidebar for the user avatar if no image is uploaded). Makes the markers less jarring in the dark theme (previously white on dark gray map) and stand out more in the light theme (white on white map).
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: