Beautify ha-attribute <pre>#8101
Merged
bramkragten merged 2 commits intohome-assistant:devfrom Jan 6, 2021
Merged
Conversation
Member
|
I think we should leave it right-aligned, having this much content in an attribute is a bad practice I guess, and shorter content would make sense to have right-aligned. This content is not really meant to be easily readable I guess? As the individual keys are also attributes? |
Member
Author
|
Yes, the attributes are basically the split up keys from the YAML. Not sure why this integration does it that way. Another case where I have seen YAML resulting in this |
bramkragten
approved these changes
Jan 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Breaking change
Proposed change
In case an attribute is in YAML form, it will be rendered as a
<pre>. That however was not nicely styled so far.I know it looks a bit jarring that we suddenly have an attribute left-aligned, but it is a lot easier to read I think. Nonetheless, I added a screenshot for right aligned as well, with the rest of the issues fixed (no more overflowing characters at the ride side).
Before:

After (left):

After (right):

Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: